-
-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated GroupFilterGambit to prevent hidden groups being visible wher… #2657
Conversation
…e they shouldn't be and to ensure that only the selected groups are returned on a search. flarum#2559
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this! The code looks good, I just have a few comments on test cases. It might also be good to test that multiple comma-separated groups can be included in the search.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we could include a test case for multiple groups in the same query? IE:
'q' => 'group:admin,mod'
or even
'q' => 'group:admin,4'
Sorry, I missed that comment the first time around. Adding now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you so much!
…e they shouldn't be and to ensure that only the selected groups are returned on a search. #2559
**Fixes #2559 **
Changes proposed in this pull request:
modify db query to use
and
instead ofor
Screenshot
n/a
Confirmed
composer test
).