Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recalculate enabled extensions and their dependencies if some listed in settings aren't installed #2629

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

askvortsov1
Copy link
Member

Fixes #2627
Fixes #1318

Changes proposed in this pull request:
On boot, if some extensions listed under "enabled" aren't installed, recalculate dependency resolution. This:

  • Ensures issues don't occur if extensions have been removed via composer (or FTP!)
  • Allows uninstalling an extension that breaks admin; otherwise, it would be enabled again when installed again, which is problematic

Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested locally.

@askvortsov1 askvortsov1 merged commit 1c578a8 into master Feb 23, 2021
@askvortsov1 askvortsov1 deleted the as/ensure-enabled-extensions-all-installed branch February 23, 2021 22:57
arthurtemple added a commit to arthurtemple/docker-flarum that referenced this pull request Jan 23, 2023
This seems to solve issue mondediefr#81 as calling /flarum/app/flarum before extensions are installed will disable them, as per flarum/framework#2629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants