Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralized IP Handler #2624

Merged
merged 4 commits into from
Feb 26, 2021
Merged

Centralized IP Handler #2624

merged 4 commits into from
Feb 26, 2021

Conversation

tankerkiller125
Copy link
Contributor

Changes proposed in this pull request:

Centralizes the IP processing/handler to a middleware that's loaded on all request (can not be removed or replaced)

Reviewers should focus on:

  • Did I find and replace all the IP insert locations
  • Is InstalledApp the best place to do this (was originally recommended by Franz)

Confirmed

  • Backend changes: tests are green (run composer test).

askvortsov1
askvortsov1 requested changes Feb 22, 2021
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd prefer ProcessIp, since it's not an event handler, but other than that, looks good to me!

We could add tests now, or when the full #2416 is implemented later down the line

@tankerkiller125 tankerkiller125 merged commit 8cc207b into master Feb 26, 2021
@tankerkiller125 tankerkiller125 deleted the mk/central-ip-handler branch February 26, 2021 01:08
@askvortsov1 askvortsov1 linked an issue Feb 26, 2021 that may be closed by this pull request
Move IP Address processing into middleware #2349
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@KyrneDev KyrneDev KyrneDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move IP Address processing into middleware
4 participants
@tankerkiller125 @KyrneDev @askvortsov1 @luceos