Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proof of Concept] ProseMirror (WIP) #2567

Closed
wants to merge 17 commits into from
Closed

[Proof of Concept] ProseMirror (WIP) #2567

wants to merge 17 commits into from

Commits on Jan 25, 2021

  1. Ultra-basic editor 

    Supports new lines, text, looks like regular editor. TODO:

- Placeholder
- Focus
- Shift-enter as equal to enter
- SuperTextarea deprecation?
- Data integration
    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    d597fa2 View commit details
    Browse the repository at this point in the history

  2. ProseMirror: Treat Shift+Enter as Enter

    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    7f883a6 View commit details
    Browse the repository at this point in the history

  3. Apply composer focus effect when ProseMirror editor in focus

    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    4e651a9 View commit details
    Browse the repository at this point in the history

  4. Move to editor folder

    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    ce49426 View commit details
    Browse the repository at this point in the history

  5. Add data flow: 

    - Create PlaintextFormatter to convert to/from super simple paragraphs
- Reorganize methods in ProseMirrorView a bit
- Make plugins a separate, ItemList powered, method
- Add support for initial value, update `app.composer.fields.content` on keypress
    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    40872b3 View commit details
    Browse the repository at this point in the history

  6. Scroll on y overflow

    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    2f10b13 View commit details
    Browse the repository at this point in the history

  7. Add placeholder

    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    5152feb View commit details
    Browse the repository at this point in the history

  8. Add undo/redo support

    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    acff49d View commit details
    Browse the repository at this point in the history

  9. Support submitting via Mod-Enter keypress

    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    def8042 View commit details
    Browse the repository at this point in the history

  10. Absorb SuperTextarea into ProseMirrorView

    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    f0d8990 View commit details
    Browse the repository at this point in the history

  11. Fix Composer's focus

    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    ed14d35 View commit details
    Browse the repository at this point in the history

  12. Add css classes during construction

    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    298eda6 View commit details
    Browse the repository at this point in the history

  13. Only apply placeholder on first line

    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    5d10ba0 View commit details
    Browse the repository at this point in the history

  14. Rename ProseMirrorView to ProseMirrorEditor 

    Also add to compat
    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    0a21165 View commit details
    Browse the repository at this point in the history

  15. Destroy prosemirror editor on composer close

    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    f526454 View commit details
    Browse the repository at this point in the history

  16. Method name cleanup

    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    bbb4a82 View commit details
    Browse the repository at this point in the history

  17. Restore disabled behavior 

    Add a new plugin that correctly applies the "disabled" attr
    @askvortsov1
    askvortsov1 committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    0d40ba2 View commit details
    Browse the repository at this point in the history