Add missing a11y attributes to "Mark as read" button on DiscussionListItem #2564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This PR adds missing accessibility attributes to the "Mark as read" button on
DiscussionListItem
.<span>
s are inherently inaccessible to keyboard users and unfocusable. Using anonClick
on them without any other attributes indicating that this performs an action is bad practice as it means keyboard navigators and screen-readers cannot access the elements, so never know that the buttons exist.Assigning unfocusable elements with a
tabindex="0"
allow them to be focuses, androle="button"
lets screen-readers know that it is a button-like element.Reviewers should focus on:
Other locations where issues like this may be present: they may be able to be bundled into one whole PR.
Screenshot
Confirmed
composer test
). (N/A)