Policies: treat true as allow, and false as deny
#2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows devs to return boolean expressions directly, which is more intuitive and simpler. ``` // Without This Change return SOME BOOLEAN LOGIC HERE ? $this->allow() : $this->deny(); // With This Change return SOME BOOLEAN LOGIC HERE; ```
[ci skip] [skip ci]
tankerkiller125
approved these changes
Jan 11, 2021
clarkwinkelmann
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Looks good!
Something else I notice now: would a comment be useful? Either in the phpdoc or above the first if, to say something like "Allow returning true and false in addition to $this->allow() and $this->deny()". To someone not in the know, this code might look like some odd unneeded redundancy
[ci skip] [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2525
This change allows devs to return boolean expressions directly, which is more intuitive and simpler.