User Preferences Extender and Tests #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
requested review from
franzliedke,
luceos,
tankerkiller125,
clarkwinkelmann,
dsevillamartin and
SychO9
SychO9
approved these changes
Nov 22, 2020
tankerkiller125
approved these changes
Nov 24, 2020
|
I like register more than add, because that makes it clear that no values are going into the preference, and this is just configuration. Perhaps we could add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1891
Replaces #2082
Changes proposed in this pull request:
Adds a simple extender and unit tests without any refactorings to the underlying preferences system. Since the public API of the extender remains unchanged, there isn't a necessity to implement refactorings in the same PR as the extender.
Confirmed
composer test).