-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access request actor in error handler #2410
Conversation
To be honest, I would prefer to see #869 happen first; that way we can start by abstracting away access, then switch up the underlying implementation. That being said, I'd lean towards not switching anything up yet, and only deprecating the old way after we abstract it away through RequestUtil. |
Sounds good, we can come back to this after #869 is implemented. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. |
This is from half a year ago???? How time flies... Anyways, this can be updated now that #2449 has been merged. |
222b350
to
3fae4e6
Compare
I would be in favor of deprecating it, and leaving it for now. |
Fixes #1847
Changes proposed in this pull request:
Very well explained here: #1847 (comment)
Reviewers should focus on:
With this, the actor can be accessed through
$request->getAttribute('actorReference')->getActor()
Do we want to deprecate
$request->getAttribute('actor')
? If so do we want to replace it with the above everywhere as well or leave that for #869 ?Confirmed
composer test
).