Remove unwanted semicolon in assets files #2280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2120
Changes proposed in this pull request:
Removes an unnecessary / unwanted semicolon that is generated in
/assets/forum-<hash>.js
and/assets/admin-<hash>.js
.As mentioned by @clarkwinkelmann the problem is found here:
https://github.com/flarum/core/blob/d492579638fb52dafbfe65f1f36a95eb6047f7f3/src/Frontend/Compiler/JsCompiler.php#L72
I simply removed the extra semicolon. No errors showing.
Confirmed
- [ ] Frontend changes: tested on a local Flarum installation.- [ ] Backend changes: tests are green (runcomposer test
).