Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix less build error. #2252

Merged
merged 1 commit into from
Aug 16, 2020
Merged

Fix less build error. #2252

merged 1 commit into from
Aug 16, 2020

Conversation

corvofeng
Copy link
Contributor

Screenshot

Fix less build error.
image

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@dsevillamartin
Copy link
Member

We should probably have semicolons there, but why are you trying to compile the Flarum LESS code using webpack or something similar? There's no need for that, the PHP compiles it.

tankerkiller125
tankerkiller125 approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@tankerkiller125 tankerkiller125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve because there should be semi-colons, with that said the error your seeing is because of Webpack (something that doesn't need to happen)

@corvofeng
Copy link
Contributor Author

@datitisev @tankerkiller125
I'd like to rewrite this project with golang, so I use webpack to build js and css files, and the flarum/core is a submodule in my project. After I updated to the latest source, I found this error.

Hope this error can be resolved soon.

@corvofeng corvofeng mentioned this pull request Aug 5, 2020
Closed
@askvortsov1 askvortsov1 merged commit 22bf03d into flarum:master Aug 16, 2020
askvortsov1 pushed a commit that referenced this pull request Sep 6, 2020
@corvofeng @askvortsov1
Fix less build error. (#2252)
5784199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@tankerkiller125 tankerkiller125 tankerkiller125 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corvofeng @dsevillamartin @tankerkiller125 @askvortsov1