Don't create user bio column #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tankerkiller125
approved these changes
Jun 28, 2020
dsevillamartin
approved these changes
Jul 1, 2020
|
That's kind of an illicit move in the migration world 😛 As long as we coordinate this with the bio extension so that no one ends up with no column at all, I'm ok with the approach. |
|
Although it's not the best practice, I feel like this is a better and cleaner option than my first approach. But yeah, might be nice to see fof adding a conditional migration that adds the column if it doesn't exist before merging this. |
|
Fof change opened in https://github.com/FriendsOfFlarum/user-bio/pull/19/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1280
Replaces #2213
See #1280 (comment)