Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple confirmation popup for hiding / deleting posts #2135

Merged

Conversation

askvortsov1
Copy link
Member

**Fixes #1966, replaces part of #2089 **

Changes proposed in this pull request:
Show confirm dialog to delete or hide posts.

Screenshot
https://youtu.be/AC9Z9A8ctm4

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@askvortsov1 askvortsov1 changed the base branch from master to v0.1.0-beta.13 April 24, 2020 21:09
Copy link
Contributor

@franzliedke franzliedke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Do we still need a PR for lang-english?

@askvortsov1
Copy link
Member Author

Yes, sorry about that. I'll have it in in 2 mins

franzliedke added a commit to flarum/lang-english that referenced this pull request Apr 24, 2020
askvortsov1 pushed a commit to flarum/lang-english that referenced this pull request Mar 11, 2022
askvortsov1 pushed a commit to flarum/lang-english that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask for confirmation when deleting a post
2 participants