Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix insertAfter and insertBefore middleware extender functions #2063

Merged
merged 3 commits into from
Mar 20, 2020
Merged

fix insertAfter and insertBefore middleware extender functions #2063

merged 3 commits into from
Mar 20, 2020

Conversation

tankerkiller125
Copy link
Contributor

@tankerkiller125 tankerkiller125 commented Mar 13, 2020 •
edited
Loading

Fixes #0000

Changes proposed in this pull request:

Fixes insertBefore and insertAfter functions of the Middleware extender.

Reviewers should focus on:

Confirmed

  • Backend changes: tests are green (run composer test).

@tankerkiller125 tankerkiller125 changed the title [WIP] fix insertAfter and insertBefore middleware extender functions fix insertAfter and insertBefore middleware extender functions Mar 14, 2020
@askvortsov1
Copy link
Member

Looks good to me!

franzliedke
franzliedke suggested changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@franzliedke franzliedke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this on the latest master so that the build is green again.

tankerkiller125 and others added 3 commits March 20, 2020 11:10
@tankerkiller125
fix: insertAfter and insertBefore middleware extender
207dba0 
Fixes the insertAfter and insertBefore functions of the middleware extender
@tankerkiller125
Fixed insertAfter and insertBefore, added testing
ee2fc7e
@luceos @tankerkiller125
Apply fixes from StyleCI
9b8f940 
[ci skip] [skip ci]
@tankerkiller125
Copy link
Contributor Author

Rebase complete

@franzliedke franzliedke merged commit 0bc06e1 into master Mar 20, 2020
@franzliedke franzliedke deleted the mk/middleware-extender-fix branch March 20, 2020 21:59
@AlexanderOMara AlexanderOMara mentioned this pull request Mar 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franzliedke franzliedke franzliedke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tankerkiller125 @askvortsov1 @franzliedke @luceos