Improved UI of Switch with loading indicator #2039
Conversation
|
I don't think this is the fix we want(ed) to go with. Apart from content jumping around horizontally when the loading indicator appears - which was mentioned by Franz, I think Franz's suggestion is a better way to tackle this.
|
|
Not 100% sure what you mean by 'jumping around horizontally': at least from my testing, the indicator doesn't displace anything, it just shows up. I'm not sure that making that switch (more) transparent would result in a more pleasant UI |
|
If the switch has items before it, it will not look well. I think what Franz was thinking of was having the loading indicator on top of the whole component with a semi-translucent background. |
|
Ah yeah that'd do it. So we could do Franz's idea with an overlay and the indicator in the middle. Alternatively, we could also move the indicator to the other side of the switch when it's going from on to off so that it's always on a white background. |
|
I think that'd get a bit confusing. Putting the loading over the whole thing is probably the best idea. |
|
Updated, how's this? |
|
Still a bit hard to read IMO, the background might still be too transparent. |
askvortsov1
changed the title
|
Just to confirm, are you proposing more or less transparency on the switch? |
|
Uh I'd say more transparent? The loading indicator isn't very visible right now. |
askvortsov1
force-pushed
the
as/improve_checkbox_loading_indicator_ui
branch
from
df35a1d
to
f43783f
Compare
|
@datitisev how's this: https://youtu.be/hYxWwHgtd6k |
|
I think that's good? It may still be hard to view for some people, but I'd rather have other members of the team comment their thoughts before making you do more work. |
|
I'm happy with the latest revision, it looks much better, the only thing I could possible think to improve is make the actual loading wheel just a tad darker maybe? |
|
How's this: https://youtu.be/4JJUz0MC6YQ? Too dark? |
|
@askvortsov1 Looks fine to me. How does it look in dark mode?
|
|
Good catch, thanks! How's this: https://youtu.be/xeuNbixI-sU? |
Fixes #1491
Changes proposed in this pull request:
Moved loading indicator outside of switch slider on settings page to improve ui
Reviewers should focus on:
Seems trivial.
Screenshot
https://i.imgur.com/6A8pGfZ.png
https://i.imgur.com/X4q7dnP.png
Confirmed