Mail Extender #2012
Merged
Mail Extender #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzliedke
suggested changes
Feb 28, 2020
askvortsov1
force-pushed
the
as/mail_driver_extender
branch
from
fa15390
to
d87cd40
Compare
Added! The tests are currently failing, but that's due to an underlying issue that I've fixed in #2036. |
franzliedke
suggested changes
Mar 6, 2020
|
Done, this now depends on #2052 to be merged first. We're going to need this authenticated request functionality anyway, so might as well get it done now! |
askvortsov1
force-pushed
the
as/mail_driver_extender
branch
from
a06a6c1
to
24c76d7
Compare
franzliedke
suggested changes
Mar 21, 2020
askvortsov1
force-pushed
the
as/mail_driver_extender
branch
from
24c76d7
to
16669ff
Compare
franzliedke
approved these changes
Apr 13, 2020
franzliedke
added a commit
that referenced
this pull request
Apr 13, 2020
- Use private over protected - Use "public" API for building requests in tests - Add more assertions - Formatting - Use correct parameter order for assertions Refs #2012.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves result of #1986
Fixes part of #1891
Changes proposed in this pull request:
Reviewers should focus on:
Confirmed
composer test).