Fix PostStreamScrubber click #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. |
askvortsov1
approved these changes
Mar 27, 2020
|
Thanks a lot @w-4 and sorry for letting you wait so long! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug. To replicate:
Go to any discussion on the desktop version, f.e. https://discuss.flarum.org/d/187-word-association-game
Click on the scrubber scrollbar, when it is not on the first position. Instead of the clicked position it will jump back to the first position.
Changes proposed in this pull request:
This is because $scrollbar.offset().top adjusts based on the scrolled position, while clientY of the mouseevent is independent of the scrolled position. Use pageY instead.
Shouldn't affect mobile, since there's no click functionality there.
Confirmed