-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Edit User permission to permissions grid #1859
Conversation
Thanks for you contributing, but please do not commit the files in the dist directory.
|
I've undone the commit and force pushed a new one that only contains the |
Code looks good, but let's not merge this until the discussion in #1845 has been resolved. |
I am closing this for now, until we have reached a decision in #1845. @tankerkiller125 Thanks a lot for your contribution! If we decide to move forward with this, we will surely reactivate this. I am just trying to keep the number of open PRs down. I hope you understand. 😉 Have a great weekend! |
@tankerkiller125 Thanks and congrats! |
Fixes #1845
Changes proposed in this pull request:
This change adds the User Edit permission to the permissions panel in the administration view
Reviewers should focus on:
General code, this is my first pull request for Flarum, the lang-eng repo will also have a pull request that adds the translation for the label
Screenshot
Confirmed
php vendor/bin/phpunit
).Required changes: