remove use of like #1787
Merged
remove use of like #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyzerner
approved these changes
May 29, 2019
franzliedke
reviewed
Jun 2, 2019
|
As @tobyzerner points the initial select is already case insensitive, can we close this without a change? |
|
Well, this PR doesn't change case-sensitivity (which is great, and I didn't know that), but it does prevent the special characters |
franzliedke
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to flarum/tags#61 (comment)
The point is that by using
likein situation where an_is used, it allows a one character replacement in MySQL. As such when you have a key namedtes_andtes1by using$key = 'tes_'it might returntes1instead, which is unwanted.There are two places this happens. The first one is in the UserRepository, which is being used by the xhr to retrieve a user profile. @meezaan reported he already experienced this issue on his installation where usernames had spaces replaced with underscores. The second one is for the settings repository, this delete method is only used inside the Setting Migration, so it can use an exact match too.