Update PULL_REQUEST_TEMPLATE.md #1505
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,24 @@ | ||
| <!-- | ||
| IMPORTANT: We applaud pull requests, they excite us every single time. As we have an obligation to maintain a healthy code standard and quality, we take considerate amounts of time for reviews. | ||
| --> | ||
|
|
||
| **Fixes #0000** | ||
|
|
||
| **Changes proposed in this pull request:** | ||
| <!-- fill this out, mention the pages and/or components which have been impacted --> | ||
|
|
||
| **Reviewers should focus on:** | ||
| <!-- fill this out, ask for feedback on specific changes you are unsure about --> | ||
|
|
||
| **Screenshot** | ||
| <!-- include an image of the most relevant user-facing change, if any --> | ||
|
|
||
| **Confirmed** | ||
|
|
||
| - [ ] for visual or frontend changes that the changes work as intended via visual confirmation on a local flarum installation. | ||
| - [ ] for php changes that the unit tests are all AOK (green) by running them locally (`php vendor/bin/phpunit`). | ||
|
|
||
| **Required changes:** | ||
|
There was a problem hiding this comment. Are these meant for suggested follow-ups (e.g. docs) or for dependent, but existing pull requests in other repos (e.g. extensions)? It wasn't clear to me... There was a problem hiding this comment. line 21 is, the lines above that are meant as checks/requirements There was a problem hiding this comment. What I'm saying is:
Or should both contain links to related PRs? There was a problem hiding this comment. Ideally docs should be PR'd at the same time (at least once we have a good foundation of docs!) There was a problem hiding this comment. So can we just combine these two with the list above?
|
||
|
|
||
| - **Docs**: <!-- list of subjects or pages --> | ||
| - **Core extensions**: <!-- list of extensions --> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay for the checklist!
Can we make these a bit shorter, though?
php vendor/bin/phpunit)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.