Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User display names #1246

Merged
merged 3 commits into from
Sep 20, 2017
Merged

User display names #1246

merged 3 commits into from
Sep 20, 2017

Commits on Sep 19, 2017

  1. Introduce user display names

    It is not uncommon for forums to be intergrated with sites where users
    don't have a unique "handle" - they might just have their first name,
    or a full name, which is not guaranteed to be unique.
    
    This commit introduces the concept of "display names" for users. By
    default display names are the same as usernames, but extensions may
    override this and set them to something different. The important thing
    is that all code should use `display_name` whenever intending to output
    a human-readable name - `username` is reserved for cases where you want
    to output a unique identifier (which may or may not be human-friendly).
    
    The new "GetDisplayName" API is probably sub-optimal, but I didn't worry
    too much because we can come up with something better in `next-back`.
    
    ref #557
    tobyzerner committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    855a6b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2017

  1. Apply fixes from StyleCI

    [ci skip] [skip ci]
    tobyzerner authored and StyleCIBot committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    03916f4 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1247 from flarum/analysis-87QMR6

    Apply fixes from StyleCI
    tobyzerner authored Sep 20, 2017
    Configuration menu
    Copy the full SHA
    7052970 View commit details
    Browse the repository at this point in the history