Apply fixes from StyleCI

[ci skip] [skip ci]
flarum · May 28, 2020 · ac7cf99 · ac7cf99
1 parent 8abff39
commit ac7cf99
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/src/Extension/Extension.php b/src/Extension/Extension.php
@@ -222,9 +222,10 @@ public function getIcon()
     }
 
     /**
-     * Get the list of flarum extensions that this extension depends on
+     * Get the list of flarum extensions that this extension depends on.
      */
-    public function getFlarumExtensionDependencies() {
+    public function getFlarumExtensionDependencies()
+    {
         return $this->composerJsonAttribute('extra.flarum-extension.dependencies.extensions');
     }
 

diff --git a/src/Extension/ExtensionManager.php b/src/Extension/ExtensionManager.php
@@ -137,12 +137,12 @@ public function enable($name)
         $missingDependencies = [];
         $enabled = $this->getEnabled();
         foreach ($extension->getFlarumExtensionDependencies() as $dependency) {
-            if (!in_array($dependency, $enabled)) {
+            if (! in_array($dependency, $enabled)) {
                 $missingDependencies[] = $dependency;
             }
         }
 
-        if (!empty($missingDependencies)) {
+        if (! empty($missingDependencies)) {
             throw new Exception\MissingDependenciesException($extension, $missingDependencies);
         }
 
@@ -190,7 +190,7 @@ public function disable($name)
             }
         }
 
-        if (!empty($dependentExtensions)) {
+        if (! empty($dependentExtensions)) {
             throw new DependentExtensionsException($extension, $dependentExtensions);
         }
 
@@ -391,7 +391,6 @@ public static function resolveExtensionOrder($extensionList)
         $pendingQueue = [];
         $inDegreeCount = []; // How many extensions are dependent on a given extension?
 
-
         foreach ($extensionList as $extension) {
             $extensionIdMapping[$extension->getId()] = $extension;
             $extensionGraph[$extension->getId()] = $extension->getFlarumExtensionDependencies();
@@ -402,7 +401,7 @@ public static function resolveExtensionOrder($extensionList)
         }
 
         foreach ($extensionList as $extension) {
-            if (!array_key_exists($extension->getId(), $inDegreeCount)) {
+            if (! array_key_exists($extension->getId(), $inDegreeCount)) {
                 $inDegreeCount[$extension->getId()] = 0;
                 $pendingQueue[] = $extension->getId();
             }
@@ -416,7 +415,7 @@ public static function resolveExtensionOrder($extensionList)
                 $inDegreeCount[$dependency] -= 1;
 
                 if ($inDegreeCount[$dependency] === 0) {
-                    if (!array_key_exists($dependency, $extensionGraph)) {
+                    if (! array_key_exists($dependency, $extensionGraph)) {
                         // Missing Dependency
                         $missingDependencies[$activeNode] = array_merge(
                             Arr::get($missingDependencies, $activeNode, []),
@@ -430,10 +429,10 @@ public static function resolveExtensionOrder($extensionList)
         }
 
         $validOutput = array_filter($output, function ($extension) use ($missingDependencies) {
-            return !array_key_exists($extension, $missingDependencies);
+            return ! array_key_exists($extension, $missingDependencies);
         });
 
-        $validExtensions = array_reverse(array_map(function($extensionId) use ($extensionIdMapping) {
+        $validExtensions = array_reverse(array_map(function ($extensionId) use ($extensionIdMapping) {
             return $extensionIdMapping[$extensionId];
         }, $validOutput)); // Reversed as required by Kahn's algorithm.
 

diff --git a/tests/unit/Foundation/ExtensionDependencyResolutionTest.php b/tests/unit/Foundation/ExtensionDependencyResolutionTest.php
@@ -28,7 +28,6 @@ public function setUp()
         $this->circular2 = new FakeExtension('circular2', ['circular1']);
     }
 
-
     /** @test */
     public function works_with_empty_set()
     {