Improve discussion page canonical URL (#2853)

* Switch to ?page= discussion page canonical URL & fix no-JS pagination buttons
flarum · May 10, 2021 · 765bd59 · 765bd59
1 parent 6ecca95
commit 765bd59
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/src/Forum/Content/Discussion.php b/src/Forum/Content/Discussion.php
@@ -50,12 +50,13 @@ public function __invoke(Document $document, Request $request)
     {
         $queryParams = $request->getQueryParams();
         $id = Arr::get($queryParams, 'id');
-        $page = max(1, intval(Arr::get($queryParams, 'page')));
+        $near = intval(Arr::get($queryParams, 'near'));
+        $page = max(1, intval(Arr::get($queryParams, 'page')), 1 + intdiv($near, 20));
 
         $params = [
             'id' => $id,
             'page' => [
-                'near' => Arr::get($queryParams, 'near'),
+                'near' => $near,
                 'offset' => ($page - 1) * 20,
                 'limit' => 20
             ]
@@ -72,10 +73,16 @@ public function __invoke(Document $document, Request $request)
         $url = function ($newQueryParams) use ($queryParams, $apiDocument) {
             $newQueryParams = array_merge($queryParams, $newQueryParams);
             unset($newQueryParams['id']);
+            unset($newQueryParams['near']);
+
+            if (Arr::get($newQueryParams, 'page') == 1) {
+                unset($newQueryParams['page']);
+            }
+
             $queryString = http_build_query($newQueryParams);
 
             return $this->url->to('forum')->route('discussion', ['id' => $apiDocument->data->attributes->slug]).
-            ($queryString ? '?'.$queryString : '');
+                ($queryString ? '?'.$queryString : '');
         };
 
         $posts = [];
@@ -86,9 +93,12 @@ public function __invoke(Document $document, Request $request)
             }
         }
 
+        $hasPrevPage = $page > 1;
+        $hasNextPage = $page < 1 + intval($apiDocument->data->attributes->commentCount / 20);
+
         $document->title = $apiDocument->data->attributes->title;
-        $document->canonicalUrl = $url([]);
-        $document->content = $this->view->make('flarum.forum::frontend.content.discussion', compact('apiDocument', 'page', 'getResource', 'posts', 'url'));
+        $document->canonicalUrl = $url(['page' => $page]);
+        $document->content = $this->view->make('flarum.forum::frontend.content.discussion', compact('apiDocument', 'page', 'hasPrevPage', 'hasNextPage', 'getResource', 'posts', 'url'));
         $document->payload['apiDocument'] = $apiDocument;
 
         return $document;

diff --git a/views/frontend/content/discussion.blade.php b/views/frontend/content/discussion.blade.php
@@ -15,11 +15,11 @@
         @endforeach
     </div>
 
-    @if (isset($apiDocument->links->prev))
+    @if ($hasPrevPage)
         <a href="{{ $url(['page' => $page - 1]) }}">&laquo; {{ $translator->trans('core.views.discussion.previous_page_button') }}</a>
     @endif
 
-    @if (isset($apiDocument->links->next))
+    @if ($hasNextPage)
         <a href="{{ $url(['page' => $page + 1]) }}">{{ $translator->trans('core.views.discussion.next_page_button') }} &raquo;</a>
     @endif
 </div>