Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions and optimize extensions page (#1379) #1496

Merged
merged 6 commits into from
Aug 21, 2018
Merged

Add descriptions and optimize extensions page (#1379) #1496

merged 6 commits into from
Aug 21, 2018

Conversation

ardacebi
Copy link
Contributor

@ardacebi ardacebi commented Jul 4, 2018

  • Adds descriptions to extensions.
  • Redesigns the extensions list (includes full titles and descriptions)

Screenshot
68747470733a2f2f6672616d617069632e6f72672f39526f46346966546a5531302f66556137584c796e50307658

Fixes change request at #1379

@franzliedke Is everything OK with this?

Copy link
Contributor

@franzliedke franzliedke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Will leave this to @tobscure, though.

@ardacebi ardacebi changed the title Add descriptions and optimise extensions page (#1379) Add descriptions and optimize extensions page (#1379) Jul 15, 2018
@KyrneDev
Copy link
Contributor

KyrneDev commented Aug 2, 2018

I personally feel instead of this would should have a tooltip with the info. I think a list could get large very fast

@ardacebi
Copy link
Contributor Author

ardacebi commented Aug 2, 2018

@cdk2020 In the future, expanding it to 2 columns can be a fix.

@ardacebi
Copy link
Contributor Author

ardacebi commented Aug 5, 2018

Seeing this after this gets merged will make it more responsive: https://discuss.flarum.org/d/14786-moving-checkboxes-over-to-extension-icons.

 Dispatch the Deserializing event in Admin Content (#1532)
@franzliedke
Copy link
Contributor

Merging as Toby already approved #1379.

@franzliedke franzliedke merged commit 190bcb5 into flarum:master Aug 21, 2018
@franzliedke franzliedke added this to the 0.1.0-beta.8 milestone Aug 21, 2018
tobyzerner pushed a commit that referenced this pull request Aug 22, 2018
* Remove `+` added from copying a diff somewhere

* Fix font-size
tobyzerner pushed a commit to flarum/pusher that referenced this pull request Aug 22, 2018
* Fix background size after flarum/framework#1496 was merged

Related to #1553

* Use percentages
askvortsov1 pushed a commit to flarum/pusher that referenced this pull request Mar 11, 2022
* Fix background size after flarum/framework#1496 was merged

Related to #1553

* Use percentages
askvortsov1 pushed a commit to flarum/pusher that referenced this pull request May 10, 2022
* Fix background size after flarum/framework#1496 was merged

Related to #1553

* Use percentages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants