Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(firebase 게시글 불러오기) #26

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

Kim-jaeyeon
Copy link
Collaborator

@Kim-jaeyeon Kim-jaeyeon commented Sep 16, 2024

PR 설명

-firebase에서 게시글 조회하기 구현 완료하였습니다!
스크린샷 2024-09-16 오후 9 48 05

-firebase에서 게시글 조회하기 구현 완료
-header가 공지사항,qna에서 가려지는 버그 z-index 수정으로 해결 완료
run prettier
Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
knuland ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 2:31pm

Copy link
Collaborator

@jjh4450 jjh4450 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헤더 수정은 차후 관련 브랜치에서 모아서 한 번에 할 예정입니다.
만약에 하실 거면 헤더 담당인 저나 지환님과 먼저 의논하셔야 했을 거 같네요….
해당 수정은 잠시 보류 부탁드립니다.

@Kim-jaeyeon
Copy link
Collaborator Author

@jjh4450 헉 그렇군요 인지하겠습니다

@Kim-jaeyeon Kim-jaeyeon changed the title Feat(firebase 게시글 불러오기, header z-index) Feat(firebase 게시글 불러오기) Sep 16, 2024
Copy link
Collaborator

@dandamdandam dandamdandam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오류 없이 잘 불러와지네요! 고생하셨습니다~!

src/pages/QnA/qna.css.ts Outdated Show resolved Hide resolved
src/pages/Notice/index.tsx Outdated Show resolved Hide resolved
@Kim-jaeyeon
Copy link
Collaborator Author

@dandamdandam 말씀주신 사항들 수정 완료했습니다~!

@dandamdandam dandamdandam self-requested a review September 17, 2024 14:55
Copy link
Collaborator

@dandamdandam dandamdandam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

팔레트 적용 감사합니다!
@jjh4450 수정사항 확인해주세요~

@dandamdandam dandamdandam requested review from jjh4450 and removed request for jjh4450 September 19, 2024 06:08
@dandamdandam dandamdandam merged commit cc9e062 into flareseek:develop Sep 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants