-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/header #18
Feat/header #18
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/shared/routing/RouterInfo.tsx
Outdated
import QnA from "../../pages/QnA"; | ||
import Timetable from "../../pages/Timetable"; | ||
|
||
export const RouterInfo: RouterInfoType[] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
컴포넌트와 구분하기 위해 camelCase로 작성해주세요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preview 사이트에서 테스트까지 확인 했습니다
lottie로 버튼 애니메이션에 메뉴 열면 블러처리까지 너무 좋아요 👍👍
고생하셨습니다!
빠른 리뷰 감사합니다! |
헤더 추가
PR 설명
src/shared/routing/RouterInfo.tsx
에서 통합적으로 이루어집니다.RouterInfo.tsx
를 기반으로 nav를 구성합니다. 컴포넌트는 별도의 수정이 필요 없습니다.기타 사항
로고를 svg로 추가했습니다.
메뉴 토글이 lottie를 통해 작동합니다.