Feat/notice crud #11
Merged
Feat/notice crud #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
flareseek
previously approved these changes
Sep 11, 2024
|
review 읽어주시고 더 의논할게 없다면 merge 해주세요! |
|
아 그리고 .env 파일 노션에다가 올려주세요! |
flareseek
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 설명
firestore 연결 후, 공지사항 crud 기능 추가하였습니다.
해당 기능 작동 확인을 위한 테스트 컴포넌트 추가하였습니다.
기타사항
noticeConverter에서 validation을 직접 구현하였는데, zod와 같은 라이브러리 이용하는게 좋을까요?