Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement alternative to stripping /@id/ prefixes when fetching modules #63

Open
jamesopstad opened this issue Nov 13, 2024 · 1 comment · May be fixed by #123
Open

Implement alternative to stripping /@id/ prefixes when fetching modules #63

jamesopstad opened this issue Nov 13, 2024 · 1 comment · May be fixed by #123
Assignees
@petebacondarwin
Milestone
Initial beta release

Comments

@jamesopstad
Copy link
Contributor

See https://github.com/flarelabs-net/vite-plugin-cloudflare/pull/57/files/1b8725bf6a9234e0185495173dfd12f37c42fc07#r1840067164
@jamesopstad jamesopstad mentioned this issue Nov 13, 2024
Merged
This was referenced Dec 10, 2024
Closed
Merged
@jamesopstad jamesopstad changed the title Investigate alternatives to stripping /@id/ prefixes when fetching modules Find alternative to stripping /@id/ prefixes when fetching modules Dec 10, 2024
@jamesopstad jamesopstad changed the title Find alternative to stripping /@id/ prefixes when fetching modules Implement alternative to stripping /@id/ prefixes when fetching modules Dec 10, 2024
@jamesopstad
Copy link
Contributor Author

jamesopstad commented Dec 10, 2024 •
edited by dario-piotrowicz
Loading

This approach has been removed as it had unintended side-effects. The nodejs_compat test have been temporarily disabled and should be reenabled as part of this issue.

@jamesopstad jamesopstad added this to the Initial beta release milestone Dec 10, 2024
@jamesopstad jamesopstad mentioned this issue Dec 16, 2024
Open
petebacondarwin added a commit that referenced this issue Dec 24, 2024
@petebacondarwin
Re-enable Node.js compatibility
653c687 
It turned out that the problems were arising because we were also creating virtual modules for Node.js aliases that were already actually expected to be external.

Fixes #63
@petebacondarwin petebacondarwin linked a pull request Dec 24, 2024 that will close this issue
Open
petebacondarwin added a commit that referenced this issue Dec 24, 2024
@petebacondarwin
Re-enable Node.js compatibility
bf9f512 
It turned out that the problems needing us to hack the `/@id/...` imports were arising because we were also creating virtual modules for Node.js aliases that were already actually expected to be external.

Fixes #63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petebacondarwin petebacondarwin

Labels
None yet
Projects
None yet
Milestone
Initial beta release
Development

Successfully merging a pull request may close this issue.

Re-enable Node.js compatibility flarelabs-net/vite-plugin-cloudflare
2 participants
@petebacondarwin @jamesopstad