-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jdk9] java.lang.Process#getPid renamed to pid #66
Conversation
Would love to see this in and released. Our instance is wrapped in a parent process which means it dies anyway, but 'unfixed' this causes a resource leak. |
@Loki-Afro @matlockx @michaelmosmann Could you please review and merge this PR? |
Still on my list, wanted to get some confidence with oder jdks |
This change would only break early access versions of Java 9 (< April 2017, see openjdk commit in #57). In the official release the change should be included so this change shouldn't be an issue |
@thetric tested this yesterday, forgot to click on merge |
Is there a milestone set in order to have a release? Can we somehow help? This is a blocker for us in terms of upgrading to JDK 9 |
@matlockx sorry to bother you again but what do you think, could you do a release of 2.0.2? |
done @Loki-Afro @ndimas @thetric |
ah wait, wrong project... let me do it again for this one... ;) was confused by the same version of mongo |
@Loki-Afro @ndimas @thetric |
I'm using this in a Java 9 project and works as expected.