Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jdk9] java.lang.Process#getPid renamed to pid #66

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

tibtof
Copy link

@tibtof tibtof commented Dec 12, 2017

I'm using this in a Java 9 project and works as expected.

@karianna
Copy link

karianna commented Jan 11, 2018

Would love to see this in and released. Our instance is wrapped in a parent process which means it dies anyway, but 'unfixed' this causes a resource leak.

@thetric
Copy link
Contributor

thetric commented Feb 2, 2018

@Loki-Afro @matlockx @michaelmosmann Could you please review and merge this PR?

@Loki-Afro
Copy link
Member

Still on my list, wanted to get some confidence with oder jdks

@thetric
Copy link
Contributor

thetric commented Feb 11, 2018

This change would only break early access versions of Java 9 (< April 2017, see openjdk commit in #57). In the official release the change should be included so this change shouldn't be an issue

@Loki-Afro
Copy link
Member

@thetric tested this yesterday, forgot to click on merge  

@Loki-Afro Loki-Afro merged commit da2c3b6 into flapdoodle-oss:process-2.x.x Feb 12, 2018
@thetric
Copy link
Contributor

thetric commented Feb 12, 2018

PR #58 and issue #57 can be closed

@ndimas
Copy link

ndimas commented Feb 13, 2018

Is there a milestone set in order to have a release? Can we somehow help?

This is a blocker for us in terms of upgrading to JDK 9

@Loki-Afro
Copy link
Member

@matlockx sorry to bother you again but what do you think, could you do a release of 2.0.2?

@matlockx
Copy link
Member

matlockx commented Feb 14, 2018

done @Loki-Afro @ndimas @thetric

@matlockx
Copy link
Member

matlockx commented Feb 14, 2018

ah wait, wrong project... let me do it again for this one... ;) was confused by the same version of mongo

@matlockx
Copy link
Member

@Loki-Afro @ndimas @thetric
ok, process 2.0.2 released and mongo 2.0.3 with process 2.0.2 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants