Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/executor json log #694

Merged
merged 10 commits into from
Dec 9, 2024
Merged

Feat/executor json log #694

merged 10 commits into from
Dec 9, 2024

Conversation

ldmonster
Copy link
Contributor

@ldmonster ldmonster commented Dec 4, 2024

Overview

When we set LOG_PROXY_HOOK_JSON env, if we have non json hook output - executor must not ignore message and log it without error, but with debug message.
When we return json log from hook, we need to nest it to our log, on the top level, with corresponding log level and message.

What this PR does / why we need it

Add executor logic for handle stdout in non JSON format
Add executor logic for nest outer log in internal log.
Bump logger lib and change old Errors logging for new field.

Special notes for your reviewer

Pavel Okhlopkov added 10 commits December 3, 2024 09:36
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
@ldmonster ldmonster self-assigned this Dec 5, 2024
@ldmonster ldmonster added the bug Something isn't working label Dec 5, 2024
@ldmonster ldmonster marked this pull request as ready for review December 5, 2024 15:20
@ldmonster ldmonster requested a review from yalosev December 5, 2024 15:20
@ldmonster ldmonster added the enhancement New feature or request label Dec 9, 2024
@yalosev yalosev merged commit 7e40c61 into main Dec 9, 2024
22 of 24 checks passed
@yalosev yalosev deleted the feat/executor-json-log branch December 9, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants