host-gw: add windows support #921

rakelkar · 2018-01-16T03:50:17Z

Description

Host GW support for windows (3a from #832) #833
Needs integration tests!!

Todos

Tests
Documentation

rakelkar · 2018-01-18T20:07:12Z

@tomdee I am having trouble updating just the gonetsh vendor version. What is the correct way to do this - issues online appear to suggest editing the lock file manually. Do you have thoughts on how to do? I want to update to rakelkar/gonetsh@758b1f7

tomdee · 2018-01-22T21:48:52Z

@rakelkar You can just update the lock file manually. I also don't mind if you end up updating other vendored libraries. If I think it's a problem to update other libraries then 'll introduce more pins in glide.yaml.

ptylenda · 2018-04-18T23:23:10Z

FYI I am sharing my Ansible playbooks for deploying windows/ubuntu cluster which has flannel with host-gw backend. Someone may find this useful I guess, unfortunately I am not able to focus on developing thexe in next weeks: https://github.com/ptylenda/kubernetes-for-windows

rocky0001 · 2018-07-11T14:05:45Z

got the error: HNS failed with error : An adapter was not found.

I0711 13:57:07.141605 4872 main.go:422] Searching for interface using 10.126.79.218
2018-07-11 13:57:07.182620 I | Interfaces : [{0 vEthernet (Ethernet 2) 25 true 10.126.79.218 24 0 10.126.79.1} {0 Loopback Pseudo-Interface 1 75 false 127.0.0.1 8 0 } {0 vEthernet (nat) 5000 true 172.29.160.1 20 0 }]
2018-07-11 13:57:07.219603 I | Found Interface for 10.126.79.218 => {15 vEthernet (Ethernet 2) 25 true 10.126.79.218 24 0 10.126.79.1}
I0711 13:57:07.221603 4872 main.go:499] Using interface with name vEthernet (Ethernet 2) and address 10.126.79.218
I0711 13:57:07.234575 4872 main.go:516] Defaulting external address to interface address (10.126.79.218)
I0711 13:57:07.237603 4872 kube.go:131] Waiting 10m0s for node controller to sync
I0711 13:57:07.238604 4872 kube.go:294] Starting kube subnet manager
I0711 13:57:08.239596 4872 kube.go:138] Node controller sync successful
I0711 13:57:08.241573 4872 main.go:240] Created subnet manager: Kubernetes Subnet Manager - ip-10-126-79-218.us-west-2.compute.internal
I0711 13:57:08.241573 4872 main.go:243] Installing signal handlers
I0711 13:57:08.241573 4872 main.go:358] Found network config - Backend type: host-gw
I0711 13:57:08.257572 4872 hostgw_windows.go:151] Attempting to create HNS network, request: {"DNSServerList":"","Name":"cbr0","Subnets":[{"AddressPrefix":"192.168.3.0/24","GatewayAddress":"192.168.3.1"}],"Type":"l2bridge"}
E0711 13:57:08.317554 4872 main.go:285] Error registering network: unable to create network [cbr0], error: HNS failed with error : An adapter was not found.
I0711 13:57:08.320573 4872 main.go:338] Stopping shutdownHandler...

pablodav · 2018-08-28T10:28:44Z

What's the status of this possible support? would be great to have support for flannel plugin on windows.

Same for #922

daschott · 2018-08-28T18:17:51Z

@pablodav Flannel in host-gw mode works today on Windows with pre-built binaries that include the open PR's, but it's not an ideal situation. Right now we are targeting this PR and working together with the maintainers to try and get basic Windows CNI plugins in which can be used by Flannel. Afterwards we will cleanup these plugins and work on tests with @madhanrm and @dineshgovindasamy as maintainers (this is a Windows only plugin, so it shouldn't break any existing CNI's for Linux). VxLAN is still under active development, including from platform perspective.

pablodav · 2018-08-29T17:00:31Z

Thaks for the update @daschott ! Sounds good to have some news and clear information where it is going!

- patch for flannel-io#921

madhanrm · 2018-09-18T01:13:29Z

FYI @nagiesek

- patch for flannel-io#921

- Add Windows host-gw (*) patch for flannel-io#921 - Add windows vxlan (*) patch for flannel-io#922

tomdee · 2018-10-05T16:53:50Z

@rakelkar What is the status of this PR? Is it ready for review and merging?

madhanrm · 2018-10-05T18:22:52Z

@tomdee Integration test is pending. Can we follow that up in a separate PR & get this one reviewed and merged?

@nagiesek can take care of the review comments.

madhanrm · 2018-10-11T17:53:16Z

@tomdee, there also seems to be another PR : #1042 which is doing similar to this PR. Can we get this PR merged & then work on top if it. The binaries out of this PR has been tested for over an year now

rajatchopra

/lgtm

Real minor nits. The PR should be ready to merge, neverthless. We should do a cosmetic code rejig in another PR to have proper common code and overriding interface implementations for windows/linux.
Also, for the gonetsh library, is there a direct kernel syscall way of managing links and routes?

rajatchopra · 2018-10-22T22:38:25Z

backend/hostgw/hostgw_network_windows.go

+	return n.extIface.Iface.MTU
+}
+
+func (n *network) Run(ctx context.Context) {


This function should be made common between linux/windows. The list of routes malloc can be part of the New/Register function itself.

we will move it in the next PR.

rajatchopra · 2018-10-22T22:48:32Z

backend/hostgw/hostgw_network_windows.go

+	name      string
+	extIface  *backend.ExternalInterface
+	linkIndex int
+	rl        []netroute.Route


A better name here possibly? 'routes'?

Will fix this in a subsequent PR.

astrieanna · 2018-10-25T21:14:24Z

I have a flannel/hostgw cluster on vsphere, with a linux node and a windows node. The one thing that doesn't work is that the linux node (the host, not a container) can't connect to windows service clusterips. This breaks accessing windows services through the NodePort on the linux node.

Does accessing a windows service via a nodeport on a linux node work for you with this PR?

- Add Windows host-gw (*) patch for flannel-io#921 - Add windows vxlan (*) patch for flannel-io#922

dineshgovindasamy · 2018-11-02T17:39:53Z

Lets abandon this PR. We are taking PR#1042 which is merged PR.

@rakelkar , can u abandon this PR?

rajatchopra · 2018-11-02T19:46:39Z

Closing this PR in favour of #1042. Please re-open if needed.

- Add Windows host-gw (*) patch for flannel-io#921 - Add windows vxlan (*) patch for flannel-io#922 Co-authored-by: rakelkar <[email protected]> Co-authored-by: madhanrm <[email protected]>

rakelkar mentioned this pull request Jan 16, 2018

Support Windows in host-gw and VXLAN modes #833

Closed

rakelkar force-pushed the windowsHostGw180115 branch from afa0df5 to 0dc90ba Compare February 4, 2018 06:26

rakelkar and others added 6 commits March 6, 2018 12:51

host-gw: add windows support

7b79445

host-gw: use interface index instead of name

9b22191

host-gw: fix RegisterNetwork fn signature

fcda80c

update gonetsh version

4f1c446

vendor hcsshim

0752d79

Fix GoFmt error

f8f5fc8

madhanrm force-pushed the windowsHostGw180115 branch from 9944210 to f8f5fc8 Compare March 7, 2018 00:26

Wait for interface

6463de9

ptylenda mentioned this pull request Apr 19, 2018

Questions about possibility to use the role in production ptylenda/kubernetes-for-windows#1

Closed

ptylenda mentioned this pull request Jul 10, 2018

Flannel unable to find interface ptylenda/kubernetes-for-windows#11

Closed

pablodav mentioned this pull request Aug 28, 2018

what's the status for flannel on windows? pablodav/kubernetes-for-windows#10

Closed

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 3, 2018

Add windows host-gw

ab6f515

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 3, 2018

Add windows host-gw

67611d5

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 3, 2018

Add windows host-gw

3d8b8e8

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 3, 2018

Add windows host-gw

25d7ac2

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 3, 2018

Add windows host-gw

46258e1

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 10, 2018

Add windows host-gw

8d5087a

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 11, 2018

Add windows host-gw

940745c

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 12, 2018

Add windows host-gw

a60ee27

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 12, 2018

Add windows host-gw

866db15

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 12, 2018

Add windows host-gw

72ba6b7

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 17, 2018

Add windows host-gw

722d707

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 18, 2018

Add windows host-gw

a3c8832

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 24, 2018

Add windows host-gw

e11d634

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 24, 2018

Add windows host-gw

6a83e63

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 24, 2018

Add windows host-gw

da6b784

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 24, 2018

Add windows host-gw

1a879e4

- patch for flannel-io#921

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 24, 2018

Add windows host-gw

d387910

- patch for flannel-io#921

thxCode mentioned this pull request Sep 24, 2018

Windows "host-gw" & "vxlan" support #1042

Merged

1 task

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 24, 2018

Windows "host-gw" and "vxlan" support

1cfb30c

- Add Windows host-gw (*) patch for flannel-io#921 - Add windows vxlan (*) patch for flannel-io#922

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 24, 2018

Windows "host-gw" and "vxlan" support

5fb56d3

- Add Windows host-gw (*) patch for flannel-io#921 - Add windows vxlan (*) patch for flannel-io#922

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Sep 24, 2018

Windows "host-gw" and "vxlan" support

2eee498

- Add Windows host-gw (*) patch for flannel-io#921 - Add windows vxlan (*) patch for flannel-io#922

tomdee added the platform/windows label Oct 5, 2018

rajatchopra approved these changes Oct 22, 2018

View reviewed changes

tomdee approved these changes Oct 25, 2018

View reviewed changes

benmoss mentioned this pull request Oct 26, 2018

Add Windows support cloudfoundry-incubator/kubo-release#264

Closed

ksubrmnn pushed a commit to ksubrmnn/flannel that referenced this pull request Oct 29, 2018

Windows "host-gw" and "vxlan" support

e2bb4c9

- Add Windows host-gw (*) patch for flannel-io#921 - Add windows vxlan (*) patch for flannel-io#922

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Oct 31, 2018

Windows "host-gw" and "vxlan" support

8b9407c

- Add Windows host-gw (*) patch for flannel-io#921 - Add windows vxlan (*) patch for flannel-io#922

thxCode added a commit to thxCode/coreos-flannel that referenced this pull request Oct 31, 2018

Windows "host-gw" and "vxlan" support

6a0758b

- Add Windows host-gw (*) patch for flannel-io#921 - Add windows vxlan (*) patch for flannel-io#922

rajatchopra closed this Nov 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

host-gw: add windows support #921

host-gw: add windows support #921

rakelkar commented Jan 16, 2018

rakelkar commented Jan 18, 2018

tomdee commented Jan 22, 2018

ptylenda commented Apr 18, 2018

rocky0001 commented Jul 11, 2018

pablodav commented Aug 28, 2018

daschott commented Aug 28, 2018

pablodav commented Aug 29, 2018

madhanrm commented Sep 18, 2018

tomdee commented Oct 5, 2018

madhanrm commented Oct 5, 2018

madhanrm commented Oct 11, 2018

rajatchopra left a comment

rajatchopra Oct 22, 2018

dineshgovindasamy Oct 24, 2018

rajatchopra Oct 22, 2018

dineshgovindasamy Oct 24, 2018

astrieanna commented Oct 25, 2018

dineshgovindasamy commented Nov 2, 2018

rajatchopra commented Nov 2, 2018

host-gw: add windows support #921

host-gw: add windows support #921

Conversation

rakelkar commented Jan 16, 2018

Description

Todos

rakelkar commented Jan 18, 2018

tomdee commented Jan 22, 2018

ptylenda commented Apr 18, 2018

rocky0001 commented Jul 11, 2018

pablodav commented Aug 28, 2018

daschott commented Aug 28, 2018

pablodav commented Aug 29, 2018

madhanrm commented Sep 18, 2018

tomdee commented Oct 5, 2018

madhanrm commented Oct 5, 2018

madhanrm commented Oct 11, 2018

rajatchopra left a comment

Choose a reason for hiding this comment

rajatchopra Oct 22, 2018

Choose a reason for hiding this comment

dineshgovindasamy Oct 24, 2018

Choose a reason for hiding this comment

rajatchopra Oct 22, 2018

Choose a reason for hiding this comment

dineshgovindasamy Oct 24, 2018

Choose a reason for hiding this comment

astrieanna commented Oct 25, 2018

dineshgovindasamy commented Nov 2, 2018

rajatchopra commented Nov 2, 2018