Try several times to contact kube-api before failing #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelbuil
force-pushed
the
addWaits
branch
2 times, most recently
from
6bbdb19 to
eeebe69
Compare
Signed-off-by: Manuel Buil <[email protected]>
rbrtbnfgl
approved these changes
May 24, 2024
thomasferrandiz
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the code tries to get a lease, it contacts kube-api. If dor some reason, the connectivity failed, flanneld will error out and the registration of the network will fail. This PR makes it try several times before really failing so that we can be more resilient.
This PR also replaces some wait.Poll() calls. That one is deprecated
Todos
Release Note