Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unimplemented error in windows trafficmngr #1938

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/trafficmngr/iptables/iptables_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ type IPTables interface {
}

func (iptm IPTablesManager) Init(ctx context.Context, wg *sync.WaitGroup) error {
return trafficmngr.ErrUnimplemented
log.Warning(trafficmngr.ErrUnimplemented)
return nil
}

func (iptm *IPTablesManager) SetupAndEnsureForwardRules(ctx context.Context, flannelIPv4Network ip.IP4Net, flannelIPv6Network ip.IP6Net, resyncPeriod int) {
Expand All @@ -46,6 +47,6 @@ func (iptm *IPTablesManager) SetupAndEnsureMasqRules(ctx context.Context, flanne
flannelIPv6Net, prevIPv6Subnet, prevIPv6Network ip.IP6Net,
currentlease *lease.Lease,
resyncPeriod int) error {
log.Error(trafficmngr.ErrUnimplemented)
log.Warning(trafficmngr.ErrUnimplemented)
return nil
}
4 changes: 2 additions & 2 deletions pkg/trafficmngr/nftables/nftables_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ type NFTablesManager struct {
}

func (nftm *NFTablesManager) Init(ctx context.Context, wg *sync.WaitGroup) error {
log.Error(trafficmngr.ErrUnimplemented)
log.Warning(trafficmngr.ErrUnimplemented)
return nil
}

Expand All @@ -41,6 +41,6 @@ func (nftm *NFTablesManager) SetupAndEnsureMasqRules(ctx context.Context, flanne
flannelIPv6Net, prevIPv6Subnet, prevIPv6Network ip.IP6Net,
currentlease *lease.Lease,
resyncPeriod int) error {
log.Error(trafficmngr.ErrUnimplemented)
log.Warning(trafficmngr.ErrUnimplemented)
return nil
}
Loading