Lowering for the Matmul Intrinsic #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanPerier
reviewed
Jul 21, 2021
flang/lib/Lower/IntrinsicCall.cpp
Outdated
| // Create mutable fir.box to be passed to the runtime for the result. | ||
| // TODO: The result can also be of rank 1 if one of the input matrices | ||
| // is of rank 1. Will this info be available at compile time or should | ||
| // code be generated to compute the rank? |
There was a problem hiding this comment.
You can compute this using matrixTmpA.rank() which will give you the argument ranks at compile time.
| auto args = | ||
| Fortran::lower::createArguments(builder, loc, fTy, resultBox, matrixABox, | ||
| matrixBBox, sourceFile, sourceLine); | ||
| return builder.create<fir::CallOp>(loc, func, args).getResult(0); |
There was a problem hiding this comment.
Shouldn't genMatmul return void ? Matmul runtime functions does not return anything.
There was a problem hiding this comment.
Yeah. :)
Initial implementation with assumption that rank will be always 2
-> Handle case where rank of one the matrices is 1. -> Add test for the above case with logical type. -> Remove return value from the matmul call.
|
ping @mleair @schweitzpgi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.