Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap to grid #3016

Merged
merged 5 commits into from
Dec 20, 2022
Merged

Snap to grid #3016

merged 5 commits into from
Dec 20, 2022

Conversation

Joshua-cla
Copy link
Contributor

@Joshua-cla Joshua-cla commented Dec 11, 2022

Little feature who add a grid in the screenshot and snap the tools to this grid.
The grid can be displayed or not and the step of grid can be adjusted. These two options can be edited in the side panel.

French translation updated.

@veracioux
Copy link
Contributor

@Joshua-cla Thank you for your contribution. I have reviewed it and it looks fine. I think the functionality is a great addition. Please just fix the formatting of the code by running clang-format -i $(git ls-files "*.cpp" "*.h") to fix the failing check.

@mmahmoudian
Copy link
Member

@Joshua-cla It seems it has passed all checks. Thanks for the PR. Although @veracioux gave a positive review, I will wait for him to merge.

@veracioux veracioux merged commit 685d0ee into flameshot-org:master Dec 20, 2022
@mmahmoudian mmahmoudian added this to the v13 milestone Dec 20, 2022
panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request Feb 18, 2023
* Add widget to side panel

* Draw grid

* snap tool to grid

* Update french translation

* Format code with clang-format

Co-authored-by: joshua <[email protected]>
(cherry picked from commit 685d0ee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants