flameshot#2856: Display main key in shortcut as lowercase #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation behind this change is that single-key character key shortcuts, currently displayed with an uppercase letter, could suggest that the shortcut includes a Shift modifier. Making the key lowercase takes away this confusion.
Tomasito665
changed the title
|
Look's good to me. The code will need to be updated if we every support stuff like Shift + a + q, Thank you! |
panpuchkov
pushed a commit
to namecheap/flameshot
that referenced
this pull request
Oct 24, 2022
…lameshot-org#2934) The motivation behind this change is that single-key character key shortcuts, currently displayed with an uppercase letter, could suggest that the shortcut includes a Shift modifier. Making the key lowercase takes away this confusion. (cherry picked from commit e691e21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request proposes to display the main key of a key shortcut in lowercase instead of uppercase. For the motivation behind this change, see the discussion on the issue. Screenshots of this fix follow below.
Lowercase s and c in ⌘s and ⌘c in the help screen.
Lowercase shortcuts in the shortcut configuration screen.
Lowercase shortcuts in the capture tool tips.
Issue
#2856