Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show post upload actions #2640

Merged
merged 1 commit into from
Jul 24, 2022

Conversation

borgmanJeremy
Copy link
Contributor

@mmahmoudian are you okay with this change? it closes #2312

@mmahmoudian
Copy link
Member

I don't understand the premise of the #2312. Reading changes of this pull request also didn't help me understand what the problem is. I'll try to compile it and see if I can figure it out from the behavior diff

@borgmanJeremy
Copy link
Contributor Author

image
That screen is only shown if "Copy URL after upload" is disabled in the options.

@mmahmoudian
Copy link
Member

I got a segfault when trying to open configuration window:

image

and this is the content of by build.sh:

#!/bin/env bash


rm -rf build

mkdir build
cd build
cmake ../
make -j$(nproc --ignore 1)

pkill flameshot
sleep 1
./src/flameshot

@borgmanJeremy
Copy link
Contributor Author

Can you post your config file? You may have found a bug

@borgmanJeremy
Copy link
Contributor Author

@mmahmoudian can you post your config? I want to resolve your seg fault before merging.

@mmahmoudian
Copy link
Member

@borgmanJeremy

[General]
allowMultipleGuiInstances=true
buttons=@Variant(\0\0\0\x7f\0\0\0\vQList<int>\0\0\0\0\x16\0\0\0\0\0\0\0\x1\0\0\0\x2\0\0\0\x3\0\0\0\x4\0\0\0\x5\0\0\0\x6\0\0\0\x12\0\0\0\xf\0\0\0\x16\0\0\0\x13\0\0\0\a\0\0\0\b\0\0\0\t\0\0\0\x10\0\0\0\n\0\0\0\v\0\0\0\r\0\0\0\x17\0\0\0\xe\0\0\0\f\0\0\0\x11)
contrastOpacity=135
copyPathAfterSave=true
disabledTrayIcon=false
drawColor=#ffff00
drawFontSize=7
drawThickness=5
ignoreUpdateToVersion=0.10.2
predefinedColorPaletteLarge=false
savePath=/home/mehrad/Pictures
savePathFixed=false
showMagnifier=false
showStartupLaunchMessage=true
startupLaunch=true
uiColor=#ff7300
undoLimit=100
uploadHistoryMax=0
useJpgForClipboard=false
userColors=picker, #800000, #ff0000, #ffff00, #00ff00, #008000, #00ffff, #0000ff, #ff00ff, #800080, #fa0164

[Shortcuts]
TYPE_ARROW=A
TYPE_CIRCLE=
TYPE_CIRCLECOUNT=
TYPE_COMMIT_CURRENT_TOOL=Ctrl+Return
TYPE_COPY=Ctrl+C
TYPE_DELETE_CURRENT_TOOL=Del
TYPE_DRAWER=D
TYPE_EXIT=Ctrl+Q
TYPE_IMAGEUPLOADER=
TYPE_MARKER=M
TYPE_MOVESELECTION=Ctrl+M
TYPE_MOVE_DOWN=Down
TYPE_MOVE_LEFT=Left
TYPE_MOVE_RIGHT=Right
TYPE_MOVE_UP=Up
TYPE_OPEN_APP=Ctrl+O
TYPE_PENCIL=
TYPE_PIN='
TYPE_PIXELATE=B
TYPE_RECTANGLE=R
TYPE_REDO=Ctrl+Shift+Z
TYPE_RESIZE_DOWN=Shift+Down
TYPE_RESIZE_LEFT=Shift+Left
TYPE_RESIZE_RIGHT=Shift+Right
TYPE_RESIZE_UP=Shift+Up
TYPE_SAVE=Ctrl+S
TYPE_SELECTION=S
TYPE_SELECTIONINDICATOR=
TYPE_SELECT_ALL=Ctrl+A
TYPE_SIZEDECREASE=-
TYPE_SIZEINCREASE=+
TYPE_TEXT=T
TYPE_TOGGLE_PANEL=Space
TYPE_UNDO=Ctrl+Z

@borgmanJeremy borgmanJeremy merged commit bd3431a into master Jul 24, 2022
panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No 'Save to disk' button visible for Imgur uploads
2 participants