fix bug on macos with save dialog #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #2270 |
panpuchkov
pushed a commit
to namecheap/flameshot
that referenced
this pull request
May 13, 2022
* fix bug on macos with save dialog * refactored Saver to not be a class since there are no member variables * removed useless comment (cherry picked from commit 74db680)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug on on MacOs. When the mime types are populated Qt reports HEIC and HEIF as seperate types. Really they are the same thing except HEIF also supports video.
The MacOs native dialog always shows heif/heic, so it was causing an off by one error. This fix removes HEIF from the list.