Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image/png on Wayland to improve copy support #1601

Merged
merged 3 commits into from
May 2, 2021
Merged

Use image/png on Wayland to improve copy support #1601

merged 3 commits into from
May 2, 2021

Conversation

nullobsi
Copy link
Contributor

@nullobsi nullobsi commented May 2, 2021

uses image/png only when wayland is detected on linux. works around a Qt bug where all images formats declared by Qt return an image in BMP format

@nullobsi
Copy link
Contributor Author

nullobsi commented May 2, 2021

closes #1568

@borgmanJeremy borgmanJeremy merged commit adcf250 into flameshot-org:master May 2, 2021
if (isLoaded) {
// Need to send message before copying to clipboard
SystemNotification().sendMessage(
QObject::tr("Capture saved to clipboard"));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sends a second notification in both branches of saveToClipboard.

@alecmev
Copy link

alecmev commented May 3, 2021

@borgmanJeremy Should this hack be removed now, perhaps?

@borgmanJeremy
Copy link
Contributor

I think that fixes a different wayland issue but would need to test it.

@nullobsi
Copy link
Contributor Author

nullobsi commented May 3, 2021

They both refer to the same Qt issue, but testing would definitely have to be done to make sure.

I've made another commit that fixes the double notification, so I open another PR as soon as I can figure out how to get github to work with me

panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request May 5, 2021
* wayland clipboard testing

* typo

* cleanup

(cherry picked from commit adcf250)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants