-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Transparency feature to pinned image #2943
Comments
I like this idea. I have it working mostly but need to add hotkey support. Check out this PR if you want to play with it early: #2944 |
Awesome. As one of control options, I would recommend holding down some key (e.g. Meta or Control) and use mouse scroll. |
Duplicate of #2251, but I closed that in favor of this issue to keep the PR number in the same issue. Also this fits well under the #954 .
In #954 it was suggested by @aurirjr that "Wheel: Zooming. Ctrl+Wheel: Rotation.". I think we should be very careful about choosing the keybinding, because changing it later would cause a lot of backlash, understandably. We can use
It is ideal to use + and - as alternative to scrolling in general. The only drawback is that unlike ISO layout, on the ANSI keyboard layout the + is triggered with Shift=. This is the issue regardless of using the QWERTY, Dvorak, or Colemak. To mitigate this, we can accept both + and Shift= at the same time.
I have no preference on the keybindings. |
Snappy on macos has a feature of pinning screenshots and lowering the opacity via numbers (e.g. 2=20%, 3=30%) |
@mmahmoudian I kind of like the idea of using numbers, what are your thoughts? |
I actually like the idea and I thought about a version of it before @eazyAlf mentioned it. What I initially thought about was something similar to what we do for tool size (accept a number typed by user in a limited time frame). But then after reading the @eazyAlf comment I thought of a mixed solution:
This second point above can be used for resizing, rotating, opacity, and any other modification that might come in the future. I think the method @eazyAlf mentioned is good for quick use and I very much like it, but not granular enough. What do you think? |
Not sure whats @kopach original use case is But I like the way you would solve it @mmahmoudian |
For me personally, |
added 10% hotkeys and 10% to the context menu. I also agree that 10% is reasonable and we don't need anything more granular than that. |
Just tested the feature from a branch - I like it a lot, works like a charm, thanks a lot @borgmanJeremy |
Feature Description
I often use "pin image" functionality to compare things. E.g. web page before and after change. It would be a really great feature to be able to change the transparency level of a pinned image. This way it would be possible to not only compare things side by side, but also by overlaying pinned image over current state and change transparency of pinned image
The text was updated successfully, but these errors were encountered: