remove param "query"

[mvenghaus]

On search results the "query" param exists in the base suggest url. If you change the search keyword the "query" param is in url and in options.

this.rq = new FactFinderAjax.Request(this.url, this.options);

And he doesn't use the new value from options.

[tuegeb]

Thanks for this pull request.

The issue cannot be reproduced. Please give us a step by step guide and more details about the shop environment (FACT-Finder version, Magento edition/version, etc.).

[mvenghaus]

• Magento 1.9.2.4
• latest version of your module
• chrome

Steps to reproduce:

• search for keyword "shirt"
• on the result page change the keyword to "shoe" in the form and wait for the suggestions
  -> suggestions are for "shirt" and not for "shoe" because "shirt" is query param in the url and "shoe" is query param in options

[tuegeb]

Thanks for the details.
Please consider also the port in the url, move the new code block to the affected block https://github.com/mvenghaus/Magento-FACTFinder/blob/3a006cc21fbdb6cd7f1ef656774dd5f205d6f4a7/src/app/code/community/FACTFinder/Suggest/Helper/Data.php#L47 and fix the formatting by replacing the tabs by four spaces.

[tuegeb]

@xpoback: Could you finalize this improvement, please?

[xpoback]

@mvenghaus Thank you for your contribution.

@tuegeb I was able to reproduce the bug: suggest proxy should be deactivated in order to do that.

I'm not completely sure it the best way to handle URLs, but I would rather use a little preg_replace(), which works perfectly and solves the problem.

[tuegeb]

@xpoback: Filter, sorting and other FACT-Finder related parameters should be dropped, too. The channel should only be retained. These URL adjustments should only be made within the branch: https://github.com/Flagbit/Magento-FACTFinder/blob/23c4ea31f134f440fc638dfdc255ffd8eeecc700/src/app/code/community/FACTFinder/Suggest/Helper/Data.php#L46

[xpoback]

@tuegeb Within which branch?

[tuegeb]

The "else" branch which is related to the suggest requests which are not using the proxy.

[xpoback]

@tuegeb
Should be fine now.