Skip to content
This repository has been archived by the owner on Mar 9, 2023. It is now read-only.

Faster image and deeplink export #101

Closed
wants to merge 1 commit into from

Conversation

marcharding
Copy link

This improves speed when images and deeplinks are exported.

In my test cases the export now takes about 50% less time and uses 10% less memory than before (ymmv).

This improves speed when images and deeplinks are exported. 

In my test cases the export now takes about 50% less time and uses 10% less memory than before (ymmv).
davidmpaz pushed a commit that referenced this pull request Mar 21, 2016
@tuegeb
Copy link
Contributor

tuegeb commented Aug 30, 2016

@xpoback: Could you check whether this improvement could be integrated into the version 4.x, please?

xpoback added a commit that referenced this pull request Aug 30, 2016
This affects performance of image and product url url export
@xpoback
Copy link
Contributor

xpoback commented Aug 30, 2016

@marcharding Many thanks for your contribution!
@tuegeb I integrated this to the current version, also added saving the image, since it was missing.
At my test instance it used about 50% less time and about 15% less memory (PHP7.0), especially in cases when no cache images were created yet.

@xpoback
Copy link
Contributor

xpoback commented Aug 31, 2016

This should also fix the issue in #173

@tuegeb
Copy link
Contributor

tuegeb commented Aug 31, 2016

@xpoback: I can confirm that it solves #173, too. Many thanks.

@xpoback xpoback closed this Sep 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants