forked from n8n-io/n8n
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(core): Augment data instead of copying it (n8n-io#5487)
- Loading branch information
Showing
3 changed files
with
666 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,143 @@ | ||
import type { IDataObject } from './Interfaces'; | ||
import util from 'util'; | ||
|
||
export function augmentArray<T>(data: T[]): T[] { | ||
let newData: unknown[] | undefined = undefined; | ||
|
||
function getData(): unknown[] { | ||
if (newData === undefined) { | ||
newData = [...data]; | ||
} | ||
return newData; | ||
} | ||
|
||
return new Proxy(data, { | ||
deleteProperty(target, key: string) { | ||
return Reflect.deleteProperty(getData(), key); | ||
}, | ||
get(target, key: string, receiver): unknown { | ||
const value = Reflect.get(newData !== undefined ? newData : target, key, receiver) as unknown; | ||
|
||
if (typeof value === 'object') { | ||
if (value === null || util.types.isProxy(value)) { | ||
return value; | ||
} | ||
|
||
newData = getData(); | ||
|
||
if (Array.isArray(value)) { | ||
Reflect.set(newData, key, augmentArray(value)); | ||
} else { | ||
// eslint-disable-next-line @typescript-eslint/no-use-before-define | ||
Reflect.set(newData, key, augmentObject(value as IDataObject)); | ||
} | ||
|
||
return Reflect.get(newData, key); | ||
} | ||
|
||
return value; | ||
}, | ||
getOwnPropertyDescriptor(target, key) { | ||
if (newData === undefined) { | ||
return Reflect.getOwnPropertyDescriptor(target, key); | ||
} | ||
|
||
if (key === 'length') { | ||
return Reflect.getOwnPropertyDescriptor(newData, key); | ||
} | ||
return { configurable: true, enumerable: true }; | ||
}, | ||
has(target, key) { | ||
return Reflect.has(newData !== undefined ? newData : target, key); | ||
}, | ||
ownKeys(target) { | ||
return Reflect.ownKeys(newData !== undefined ? newData : target); | ||
}, | ||
set(target, key: string, newValue: unknown) { | ||
if (newValue !== null && typeof newValue === 'object') { | ||
// Always proxy all objects. Like that we can check in get simply if it | ||
// is a proxy and it does then not matter if it was already there from the | ||
// beginning and it got proxied at some point or set later and so theoretically | ||
// does not have to get proxied | ||
newValue = new Proxy(newValue, {}); | ||
} | ||
|
||
return Reflect.set(getData(), key, newValue); | ||
}, | ||
}); | ||
} | ||
|
||
export function augmentObject<T extends object>(data: T): T { | ||
const newData = {} as IDataObject; | ||
const deletedProperties: Array<string | symbol> = []; | ||
|
||
return new Proxy(data, { | ||
get(target, key: string, receiver): unknown { | ||
if (deletedProperties.indexOf(key) !== -1) { | ||
return undefined; | ||
} | ||
|
||
if (newData[key] !== undefined) { | ||
return newData[key]; | ||
} | ||
|
||
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment | ||
const value = Reflect.get(target, key, receiver); | ||
|
||
if (value !== null && typeof value === 'object') { | ||
if (Array.isArray(value)) { | ||
newData[key] = augmentArray(value); | ||
} else { | ||
newData[key] = augmentObject(value as IDataObject); | ||
} | ||
|
||
return newData[key]; | ||
} | ||
|
||
return value as string; | ||
}, | ||
deleteProperty(target, key: string) { | ||
if (key in newData) { | ||
delete newData[key]; | ||
} | ||
if (key in target) { | ||
deletedProperties.push(key); | ||
} | ||
|
||
return true; | ||
}, | ||
set(target, key: string, newValue: unknown) { | ||
if (newValue === undefined) { | ||
if (key in newData) { | ||
delete newData[key]; | ||
} | ||
if (key in target) { | ||
deletedProperties.push(key); | ||
} | ||
return true; | ||
} | ||
|
||
newData[key] = newValue as IDataObject; | ||
|
||
const deleteIndex = deletedProperties.indexOf(key); | ||
if (deleteIndex !== -1) { | ||
deletedProperties.splice(deleteIndex, 1); | ||
} | ||
|
||
return true; | ||
}, | ||
ownKeys(target) { | ||
return [...new Set([...Reflect.ownKeys(target), ...Object.keys(newData)])].filter( | ||
(key) => deletedProperties.indexOf(key) === -1, | ||
); | ||
}, | ||
|
||
// eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
getOwnPropertyDescriptor(k) { | ||
return { | ||
enumerable: true, | ||
configurable: true, | ||
}; | ||
}, | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.