Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding=same, support half-precision input #18

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Conversation

papkov
Copy link
Contributor

@papkov papkov commented Mar 21, 2022

  • Calculate padding size based on kernel for stride=1, dilation=1
  • Convert half-precision signal and kernel to float, because rfftn does not support half at the moment
  • Remove unnecessary signal copy in padding

@fkodom
Copy link
Owner

fkodom commented Mar 23, 2022

Thanks for this contribution! Just FYI -- I'll probably get to look over this in the next few days. Super busy lately haha 👍

@D1anskr
Copy link

D1anskr commented Jun 28, 2022

If an RGB image is convoluted, is it 2D or 3D? Can there be a demonstration about fast convolution of pictures

@lukepolson
Copy link

Is this going to be merged?

Copy link
Owner

@fkodom fkodom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey folks -- really sorry about this. It somehow slipped through the cracks, and I forgot it was still open. 🙁

I agree this is a good contribution. All tests passing, and very clean implementation. 🎉

@fkodom fkodom merged commit 0fdddc6 into fkodom:master Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants