Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Removing dependency to react-transition-group #514

Closed
fkhadra opened this issue Aug 5, 2020 · 1 comment · Fixed by #554
Closed

[WIP] Removing dependency to react-transition-group #514

fkhadra opened this issue Aug 5, 2020 · 1 comment · Fixed by #554
Assignees
@fkhadra
Labels
Feature Request Merged in next Merged but not live

Comments

@fkhadra
Copy link
Owner

fkhadra commented Aug 5, 2020

No description provided.

@fkhadra fkhadra self-assigned this Aug 5, 2020
@Avi98
Copy link

Avi98 commented Sep 27, 2020 •
edited
Loading

@fkhadra I can try to start working on it

@fkhadra fkhadra changed the title [UNDER ANALYSIS] Removing dependency to react-transition-group [WIP] Removing dependency to react-transition-group Dec 20, 2020
@fkhadra fkhadra mentioned this issue Dec 20, 2020
Closed
@fkhadra fkhadra added the Merged in next Merged but not live label Dec 23, 2020
@fkhadra fkhadra mentioned this issue Dec 29, 2020
Merged
@fkhadra fkhadra linked a pull request Jan 25, 2021 that will close this issue
Next release #554
Merged
fkhadra added a commit that referenced this issue Jan 25, 2021
@fkhadra
Merge pull request #554 from fkhadra/next
cc011ea 
## 💥 Breaking changes

- dependency to react-transition-group has been removed #514
- the `duration` parameter has been removed from `cssTransition`. Css animations just works now out of the box. Check the codesanbox below  
- the border-radius has been increased a bit

##  🚀 Features

- Css animation just works! 
[![View](https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/s/react-toastify-animatecss-jxrx9?fontsize=14&hidenavigation=1&theme=dark&view=preview)

- add a way to load the CSS without a CSS loader
[![Edit react-toastify-inject-style](https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/s/react-toastify-inject-style-qfg0l?fontsize=14&hidenavigation=1&theme=dark)
- specify swipe direction, close #512 . Thanks to @denydavy
[![Edit react-toastify-drag-y](https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/s/react-toastify-drag-y-lh88i?fontsize=14&hidenavigation=1&theme=dark)
- bundle size reduced from ~7k to ~5k!
- remove the dependency on prop-types.

## 🐛 Bugfix

- fix #541 apply pauseOnFocusLoss on first render
- fix #538 react-dom should be a peer dep
- fix #530 change id generation
- fix #534 #483 toastId cannot be reused
- fix #511 by removing react-transition-group
- fix #550 Unable to select text inside inputs when a toast is open
- fix #555 The toast timer starts after you click on the toast
This was referenced Mar 17, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fkhadra fkhadra

Labels
Feature Request Merged in next Merged but not live
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Next release fkhadra/react-toastify
2 participants
@fkhadra @Avi98