-
-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: newestOnTop prop is not working on production build #1140
Comments
I'm also running into this exact same issue. It appears like newestOnTop works on localhost but not after a build: Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React? React: ^18.2.0 |
any update on this issue? |
No updates since I issued 🥲 |
Any thoughts about what the fix might be? Seems like it would have to be this line in containerObserver.ts
Could it be that reverse is done in place? Though it's weird that it works running locally. I tried building the code locally, but haven't had any luck yet, I'm guessing because I'm on Windows.
I was hoping to try and debug it and see if this worked
Don't have much time for it today though. This is a really nice feature that I hope works at some point. |
Not 100% sure if this is how it should be done, but when I ran things with this change (both locally and with a build and deployment) it seemed to work.
My previous comment wouldn't fix it, it caused more trouble. I do think I found a fix though. I'm not sure if it's the best approach, but it seems to work. |
Looking into it |
Not 100% sure if this is how it should be done, but when I ran things with this change (both locally and with a build and deployment) it seemed to work.
The fix has been released. |
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Toast stacked like newestOnTop={false} on production build
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your CodeSandbox (https://codesandbox.io/s/new) example below:
What is the expected behavior?
Toast will stack like newestOnTop={true} on production build
Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
The text was updated successfully, but these errors were encountered: