Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake : correct project name and precise VTK version #1123

Merged
merged 1 commit into from
Apr 11, 2017

Conversation

mehdi-benallegue
Copy link
Contributor

I had a lot of trouble figuring out the reason the link error when linking with VTK 7. This fix solved the problem.

@k-okada
Copy link
Contributor

k-okada commented Apr 10, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2837/
Test PASSed.

@fkanehiro
Copy link
Owner

@k-okada さん、プロジェクト名を変えると色々コケてしまうようですが、プロジェクト名を正しくする、というのも一理あると思います。どうしたものでしょうか。

@fkanehiro
Copy link
Owner

@mehdi-benallegue , could you split this PR into two PRs?
Because correcting the project name affect other packages.

@k-okada
Copy link
Contributor

k-okada commented Apr 11, 2017

そうですね
実害がなければ変更なしが安全とは思います
実害があるなら検討します

There seems to be an incompatibility between the version 5.8 and the version 7
@mehdi-benallegue
Copy link
Contributor Author

mehdi-benallegue commented Apr 11, 2017

The PR is split now. Only the VTK fix is now in this one.

Regarding the project name. As far as I know I did not experience any problem with changing the project name of CMake, since it is used nowhere and the line 104 of /CMakeLists.txt gives
set(CPACK_PACKAGE_NAME hrpsys-base)

However, the default cmake project name is important when generating a project for IDEs such as CodeBlocks; since it gives the name of the main file.

I will make a new PR.

@k-okada
Copy link
Contributor

k-okada commented Apr 11, 2017

Refer to this link for build results (access rights to CI server needed):
http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2838/
Test PASSed.

@fkanehiro fkanehiro merged commit 2228c59 into fkanehiro:master Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants