卒業証書のPDFファイルをアップロードできる機能を追加 #8190
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,52 +75,53 @@ function extractField(elements) { | |
| } | ||
| } | ||
|
|
||
| function initializePdfUploadField() { | ||
| const uploadField = document.getElementById('js-pdf-upload-field') | ||
| if (!uploadField) return | ||
|
|
||
| const removeButton = document.getElementById('js-remove-pdf-button') | ||
| const fileLink = document.getElementById('js-pdf-file-link') | ||
| const removeFlag = document.getElementById('js-remove-pdf-flag') | ||
| const fileNameDisplay = document.getElementById('js-pdf-name') | ||
|
There was a problem hiding this comment. 提案です！ |
||
| const fileInput = uploadField.querySelector('input[type="file"]') | ||
|
|
||
| const updateFileNameDisplay = (name = '') => { | ||
|
There was a problem hiding this comment. 提案です！ |
||
| if (name) { | ||
|
There was a problem hiding this comment. こんな感じで書けそうです🙆 fileNameDisplay.textContent = name
const displayedStatus = name ? 'block' : 'none'
fileNameDisplay.style.display = displayedStatusThere was a problem hiding this comment. 指摘された点とfileInputのイベントリスナーのロジックもリファクタリングしました。 |
||
| fileNameDisplay.textContent = name | ||
| fileNameDisplay.style.display = 'block' | ||
| } else { | ||
| fileNameDisplay.textContent = '' | ||
| fileNameDisplay.style.display = 'none' | ||
| } | ||
| } | ||
|
|
||
|
There was a problem hiding this comment. 今回実装する部分を関数にして↑の DOMContentLoadedに入れてはどうでしょうか？ あと画面の読み込み時に実行していますが、該当する画面でない場合のreturnがなさそうです。 |
||
| removeButton.addEventListener('click', () => { | ||
| if (fileLink) fileLink.style.display = 'none' | ||
|
There was a problem hiding this comment. ファイルがアップロードされている時のみ削除ボタンが表示されていれば、if文は不要になるかもです There was a problem hiding this comment. fileLinkはHTMLが生成されない場合があるのでエラーになるようです。 |
||
| uploadField.style.display = 'flex' | ||
| fileInput.value = '' | ||
| removeFlag.value = '1' | ||
| updateFileNameDisplay() | ||
| }) | ||
|
|
||
| fileInput.addEventListener('change', () => { | ||
| if (fileInput.files && fileInput.files[0]) { | ||
| const fileName = fileInput.files[0].name | ||
| updateFileNameDisplay(fileName) | ||
| removeFlag.value = '0' | ||
| } else { | ||
| updateFileNameDisplay() | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| document.addEventListener('DOMContentLoaded', () => { | ||
| const ref = document.querySelector('#reference_books') | ||
| if (ref) { | ||
| $(ref).on('cocoon:after-insert', (_, target) => { | ||
| const added = extractField(target) | ||
| initializeFileInput(added) | ||
| }) | ||
| } | ||
| initializeFileInput(document) | ||
| initializePdfUploadField() | ||
| }) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
提案です！
initializeDiplomaUploadFieldの方がいいかも？