-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2024-11-18 04:22:29 +0000 #8180
Open
github-actions
wants to merge
208
commits into
production
Choose a base branch
from
main
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,758
−1,080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
commented
Nov 7, 2024
•
edited
Loading
edited
- FAQにカテゴリを追加する #7093 @komagata
- company-products.vueとcompany-users.vueを非Vue化した #7789 @ham-cap
- 「参考書籍一覧」を非Vue化した #8055 @ham-cap
- 日報が確認OKされていない場合、メンターがコメントした時にアラートが出るように実装 #8061 @su-su-su-su
- learning.vueを非Vue化した #8131 @Shrimprin
- 他のユーザーのメール通知設定を変更できないようにした #8149 @Ryooo-k
- 休会・退会したら参加している定期イベントはキャンセルされる #8152 @MikotoMakizuru
- コース別ユーザー一覧ページにおいて「その他」のコースに所属するユーザーが表示されない不具合を修正した #8169 @ham-cap
・絞り込み機能使用時にサーバーに送信されるのはGETリクエストのみであり、authenticity_tokenがパラメータに含まれるのは不自然であるため、調査のうえ修正した。 参考:https://railsguides.jp/form_helpers.html#%E5%9F%BA%E6%9C%AC%E7%9A%84%E3%81%AA%E3%83%95%E3%82%A9%E3%83%BC%E3%83%A0%E3%82%92%E4%BD%9C%E6%88%90%E3%81%99%E3%82%8B
・管理者かメンターであることを確認するメソッドがconcernsにあるため、そちらを使用するように変更した。
・ユーザーを絞り込む際にpublishedフラグがtrueのコースだけを対象にしていたが、 「その他」のコースは全て非公開コースのため一覧に表示されなくなってしまったのを修正した。
・提出物のタイトル、ユーザー名、提出物の状態(作成中・提出)の表示を実装した。
動かなくなったFAQの順番移動を動くようにした
github-actions
bot
changed the title
Release 2024-11-15 05:23:15 +0000
Release 2024-11-18 04:22:29 +0000
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.