-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
「参考書籍一覧」を非Vue化した #8055
Merged
Merged
「参考書籍一覧」を非Vue化した #8055
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8438a1f
参考書籍一覧のフィルター以外の部分をHTMLに置き換えた
ham-cap 56407ec
参考書籍一覧のフィルター部分を非Vue化
ham-cap 9d388e7
参考書籍の絞り込み機能使用時、URLのパラメータにauthenticity_tokenが含まれてしまう不具合を修正
ham-cap 5741156
不要になったVueコンポーネントを削除
ham-cap a51d9fd
if文の条件式の書き方を変更
ham-cap 7584f78
不要なdivを削除した
ham-cap 24dd050
aタグで記述されていた箇所をlink_toに置き換えた
ham-cap 0d87637
インデントを調整
ham-cap File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,50 @@ | ||||||||||||||||||
.col-xxxl-2.col-xxl-3.col-xl-4.col-lg-4.col-md-6.col-xs-12 | ||||||||||||||||||
.card-books-item.a-card | ||||||||||||||||||
.card-books-item__body | ||||||||||||||||||
.card-books-item__inner | ||||||||||||||||||
.card-books-item__start | ||||||||||||||||||
= link_to book.page_url, | ||||||||||||||||||
target: '_blank', | ||||||||||||||||||
rel: 'noopener', | ||||||||||||||||||
class: 'card-books-item__cover-container' do | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
で行けた気がします。 |
||||||||||||||||||
= image_tag book.cover_url, | ||||||||||||||||||
title: book.page_url, | ||||||||||||||||||
alt: book.title, | ||||||||||||||||||
class: 'card-books-item__image' | ||||||||||||||||||
.card-books-item__end | ||||||||||||||||||
.card-books-item__rows | ||||||||||||||||||
.card-books-item__row | ||||||||||||||||||
h2.card-books-item__title | ||||||||||||||||||
- if book.must_read_for_any_practices? | ||||||||||||||||||
span.a-badge.is-danger.is-sm | ||||||||||||||||||
| 必読 | ||||||||||||||||||
= link_to book.page_url, | ||||||||||||||||||
target: '_blank', | ||||||||||||||||||
rel: 'noopener', | ||||||||||||||||||
class: 'card-books-item__title-link' do | ||||||||||||||||||
span.card-books-item__title-label | ||||||||||||||||||
| #{book.title} | ||||||||||||||||||
.card-books-item__row | ||||||||||||||||||
p.card-books-item__price | ||||||||||||||||||
| #{book.price.to_s(:delimited)}円(税込) | ||||||||||||||||||
- if book.description | ||||||||||||||||||
.card-books-item__row | ||||||||||||||||||
.card-books-item__description | ||||||||||||||||||
.a-short-text | ||||||||||||||||||
p | ||||||||||||||||||
|#{book.description} | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||
.card-books-item__practices | ||||||||||||||||||
.tag-links | ||||||||||||||||||
ul.tag-links__items | ||||||||||||||||||
- book.practices.each do |practice| | ||||||||||||||||||
li.tag-links__item | ||||||||||||||||||
= link_to practice.path, class: 'tag-links__item-link' do | ||||||||||||||||||
| #{practice.title} | ||||||||||||||||||
hr.a-border-tint | ||||||||||||||||||
- if admin_or_mentor_login? | ||||||||||||||||||
footer.card-footer.is-only-mento | ||||||||||||||||||
.card-main-actions | ||||||||||||||||||
ul.card-main-actions__items | ||||||||||||||||||
li.card-main-actions__item | ||||||||||||||||||
= link_to edit_book_path(book), class: 'card-main-actions__action a-button is-sm is-secondary is-block' do | ||||||||||||||||||
| 編集 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
でよかった気がします〜
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@komagata
こちら、この位置で揃えないとRubocopの
Layout/MultilineMethodCallIndentation
というルールに引っかかってしまうのですが、大丈夫でしょうか?👀There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
すみません、上記だとrubocopに引っかかるんですね。
下記はいかがでしょうか。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@komagata
こちらの書き方で大丈夫でした🙆