空の/buzzアクセス時の500エラーを修正 #6754
Merged
空の/buzzアクセス時の500エラーを修正 #6754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komagata
reviewed
Jul 23, 2023
app/controllers/buzz_controller.rb
Outdated
| @@ -23,6 +23,7 @@ def update | |||
|
|
|||
| def set_buzz | |||
| @buzz = Buzz.first | |||
| @buzz ||= Buzz.create(body: 'test') | |||
There was a problem hiding this comment.
testという文字列が本番環境で出てくるということなのでこれは問題があると思います。
seedとdata-migrationに適切な初期データを入れるといいと思います。
適切な初期データは @machida さんに聞いてみてください。
|
@djkazunoko @komagata デザインを調整して、初期データも変更しましたー |
|
緊急の対応として本番DBを直接いじって修正しておきました。 それとは別にこちらのPRは進めていただければと思います〜。 |
|
了解ですー👍
|
|
@djkazunoko rubocop が通らないみたいで CI が取っていない状況です。こちら見ていただきたいですー |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
/buzzにアクセスすると500: Internal Server Errorが表示される #6753